Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46671 )
Change subject: mb/google/zork: Generate acpi methods in mainboard.c ......................................................................
Patch Set 1:
(2 comments)
You will also have to drop: https://source.corp.google.com/chromeos_public/src/third_party/coreboot/src/...
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... File src/mainboard/google/zork/mainboard.c:
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 178: nit: You can add macros for the method names just to make it easier to reuse below:
#define METHOD_BACKLIGHT_ENABLE "\_SB.BKEN" #define METHOD_BACKLIGHT_DISABLE "\_SB.BKDS" #define METHOD_MAINBOARD_INI "\_SB.MINI" ...
https://review.coreboot.org/c/coreboot/+/46671/1/src/mainboard/google/zork/m... PS1, Line 181: These should be all tabs instead of spaces.