Attention is currently required from: Felix Singer.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49200 )
Change subject: mb/google/parrot: Let else statement follow closing brace
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/parrot/smihandler.c:
https://review.coreboot.org/c/coreboot/+/49200/comment/545d3ac7_cb6b812b
PS1, Line 42: while (mainboard_smi_ec() != EC_NO_EVENT);
Ah, just noticed that I've done it in CB:49201 😄
No, I meant an empty line to separate the if-block from the else-block. It's not related to the semicolon.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49200
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1302e32b0d52e37d9cb4503128edc7d1df1c3bd8
Gerrit-Change-Number: 49200
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Fri, 08 Jan 2021 13:03:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment