Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40346 )
Change subject: sb/intel/bd82x6x/elog.c: add missing power button events ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40346/2/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/elog.c:
https://review.coreboot.org/c/coreboot/+/40346/2/src/southbridge/intel/bd82x... PS2, Line 57: elog_add_event(ELOG_TYPE_POWER_BUTTON); Isn’t that check the same as below? Other devices do not have this in `elog.c`.
``` $ git grep ELOG_TYPE_POWER_BUTTON | grep elog.c src/soc/intel/apollolake/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/baytrail/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/braswell/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/broadwell/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/cannonlake/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/icelake/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/jasperlake/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/skylake/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/tigerlake/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/southbridge/intel/bd82x6x/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/southbridge/intel/lynxpoint/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); ```