Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40346 )
Change subject: sb/intel/bd82x6x/elog.c: add missing power button events ......................................................................
sb/intel/bd82x6x/elog.c: add missing power button events
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: I233575751c375172ac9dced10b6c13acc33e0445 --- M src/southbridge/intel/bd82x6x/elog.c 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/40346/1
diff --git a/src/southbridge/intel/bd82x6x/elog.c b/src/southbridge/intel/bd82x6x/elog.c index dc5da79..99e3d9c 100644 --- a/src/southbridge/intel/bd82x6x/elog.c +++ b/src/southbridge/intel/bd82x6x/elog.c @@ -52,6 +52,10 @@ if (pm1_sts & (1 << 11)) elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE);
+ /* Power Button */ + if (pm1_sts & (1 << 8)) + elog_add_event(ELOG_TYPE_POWER_BUTTON); + /* System Reset Status (reset button pushed) */ if (gen_pmcon_2 & (1 << 4)) elog_add_event(ELOG_TYPE_RESET_BUTTON); @@ -69,6 +73,9 @@ * Wake sources */
+ /* Power Button */ + if (pm1_sts & (1 << 8)) + elog_add_event_wake(ELOG_WAKE_SOURCE_PWRBTN, 0); /* RTC */ if (pm1_sts & (1 << 10)) elog_add_event_wake(ELOG_WAKE_SOURCE_RTC, 0);
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40346 )
Change subject: sb/intel/bd82x6x/elog.c: add missing power button events ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40346/2/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/elog.c:
https://review.coreboot.org/c/coreboot/+/40346/2/src/southbridge/intel/bd82x... PS2, Line 57: elog_add_event(ELOG_TYPE_POWER_BUTTON); Isn’t that check the same as below? Other devices do not have this in `elog.c`.
``` $ git grep ELOG_TYPE_POWER_BUTTON | grep elog.c src/soc/intel/apollolake/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/baytrail/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/braswell/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/broadwell/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/cannonlake/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/icelake/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/jasperlake/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/skylake/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/soc/intel/tigerlake/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/southbridge/intel/bd82x6x/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); src/southbridge/intel/lynxpoint/elog.c: elog_add_event(ELOG_TYPE_POWER_BUTTON_OVERRIDE); ```
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40346?usp=email )
Change subject: sb/intel/bd82x6x/elog.c: add missing power button events ......................................................................
Abandoned
-
Michał Żygowski (Code Review) -
Paul Menzel (Code Review)
-
Stefan Reinauer (Code Review)