[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add field to identify single channel memory

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31262 )

Change subject: soc/intel/cannonlake: Add field to identify single channel memory
......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/#/c/31262/10/src/soc/intel/cannonlake/cnl_memcfg... 
File src/soc/intel/cannonlake/cnl_memcfg_init.c:

https://review.coreboot.org/#/c/31262/10/src/soc/intel/cannonlake/cnl_memcfg... 
PS10, Line 19: #include <soc/gpio.h>
> Why is this required?

I thought that this was needed for other boards.  You had commented in patchset 5:

I think you need to include soc/gpio.h here and that will include the right gpio_soc_defs / gpio_soc_defs_cnp_h header file based on the PCH type.

https://review.coreboot.org/#/c/31262/10/src/soc/intel/cannonlake/cnl_memcfg... 
PS10, Line 53: cnl_cfg
> maybe cnl_mb_cfg?

I think that Patrick commented that the name should be the same as others below, which used the name cnl_cfg.