View Change

2 comments:

• File src/soc/intel/cannonlake/cnl_memcfg_init.c:

  • Patch Set #10, Line 19: #include <soc/gpio.h>

    Why is this required?

    I thought that this was needed for other boards. You had commented in patchset 5:

    I think you need to include soc/gpio.h here and that will include the right gpio_soc_defs / gpio_soc_defs_cnp_h header file based on the PCH type.

  • Patch Set #10, Line 53: cnl_cfg

    maybe cnl_mb_cfg?

    I think that Patrick commented that the name should be the same as others below, which used the name cnl_cfg.

To view, visit change 31262. To unsubscribe, or for help writing mail filters, visit settings.