Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 )
Change subject: payloads/cbui: Add new payload CBUI ......................................................................
Patch Set 55:
(43 comments)
File payloads/cbui/NuklearUI/NuklearDatePicker.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/c79e0252_93e66b0d PS55, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/43046617_154d527f PS55, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment
File payloads/cbui/NuklearUI/NuklearRW.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/de183aed_fa5d1031 PS55, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/4f2017bf_61373ec9 PS55, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAcpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/af583c9c_28fd5ccc PS55, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/437324eb_794028bb PS55, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/fa2faff2_4387c6a8 PS55, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/462a630b_946e8aa5 PS55, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwClock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/7883a495_60447d9f PS55, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/1d12086e_580070ae PS55, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/23c922c0_fea99cdc PS55, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/3471b86a_c0ea0dd7 PS55, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/5263bfdb_8e4ee0e1 PS55, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin", static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/43f1efa2_84a4f5ba PS55, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const
File payloads/cbui/NuklearUI/NuklearRwE820.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/25b7d39c_581ca9e6 PS55, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const
File payloads/cbui/arch/x86/int32.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/77a6976a_b15bc375 PS55, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed))
File payloads/cbui/arch/x86/int32.nasm:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/9aa1baa6_4d32f5d2 PS55, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'?
File payloads/cbui/gfx/vbe.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/b212e163_dc96c13c PS55, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem")))
File payloads/cbui/lang/de.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/f43edd47_c605539b PS55, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/69a9519b_a66a8784 PS55, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/b45f1ba2_07e07060 PS55, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/d0818f2e_7f10eb4f PS55, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/2066e0b5_f098d934 PS55, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/b50b0d4f_0a7d2982 PS55, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/c4b1aa67_ba50a3d1 PS55, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/7e580acd_408d60b4 PS55, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations
File payloads/cbui/lang/en.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/73b34609_e69f878b PS55, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/5b6fe371_9b044fba PS55, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/b8d89005_2a3a7aac PS55, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/d21725f0_147b20da PS55, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/7c7703c7_1008b332 PS55, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations
File payloads/cbui/modules/bootlog_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/ef8d55a3_52d57328 PS55, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/ef403bc3_3dbc3411 PS55, Line 82: } void function return statements are not generally useful
File payloads/cbui/modules/cbfs_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/5d162a65_43f1ea77 PS55, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/43821d43_1a32af9a PS55, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed))
File payloads/cbui/modules/cpuinfo_module.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/b0005b22_8db521ae PS55, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/410f2bc4_518903b9 PS55, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/2be273c1_bf12124d PS55, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/888fcc54_9ebd46fb PS55, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/702b458c_ef5d2715 PS55, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/939ee377_0ffa0730 PS55, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/4de23b73_7a709c88 PS55, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860): https://review.coreboot.org/c/coreboot/+/23586/comment/5b9d0b19_1896e45d PS55, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const