Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph.

View Change

43 comments:

• File payloads/cbui/NuklearUI/NuklearDatePicker.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 36: case 6: /* fallthrough */

    Prefer 'fallthrough;' over fallthrough comment

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 37: case 9: /* fallthrough */

    Prefer 'fallthrough;' over fallthrough comment

• File payloads/cbui/NuklearUI/NuklearRW.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" };

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 323: static const char *entries[] = { "NVRAM" };

    static const char * array should probably be static const char * const

• File payloads/cbui/NuklearUI/NuklearRwAcpi.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate(

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG",

    static const char * array should probably be static const char * const

• File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate(

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" };

    static const char * array should probably be static const char * const

• File payloads/cbui/NuklearUI/NuklearRwClock.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load",

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" };

    static const char * array should probably be static const char * const

• File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) };

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" };

    static const char * array should probably be static const char * const

• File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin",

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" };

    static const char * array should probably be static const char * const

• File payloads/cbui/NuklearUI/NuklearRwE820.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) };

    static const char * array should probably be static const char * const

• File payloads/cbui/arch/x86/int32.h:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 20: typedef struct __attribute__ ((packed)) {

    Prefer __packed over __attribute__((packed))

• File payloads/cbui/arch/x86/int32.nasm:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 38: struc regs16_t

    'struc' may be misspelled - perhaps 'struct'?

• File payloads/cbui/gfx/vbe.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem")));

    Prefer __section(".lowmem") over __attribute__((section(".lowmem")))

• File payloads/cbui/lang/de.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \

    Avoid unnecessary line continuations

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 44: "Der coreboot framebuffer hat keine physikalische " \

    Avoid unnecessary line continuations

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \

    Avoid unnecessary line continuations

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \

    Avoid unnecessary line continuations

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \

    Avoid unnecessary line continuations

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \

    Avoid unnecessary line continuations

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \

    Avoid unnecessary line continuations

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \

    Avoid unnecessary line continuations

• File payloads/cbui/lang/en.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \

    Avoid unnecessary line continuations

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \

    Avoid unnecessary line continuations

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \

    Avoid unnecessary line continuations

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 81: "ERROR: No timestamps found. Please make sure to enable " \

    Avoid unnecessary line continuations

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \

    Avoid unnecessary line continuations

• File payloads/cbui/modules/bootlog_module.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 28: } __attribute__ ((__packed__));

    Prefer __packed over __attribute__((__packed__))

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 82: }

    void function return statements are not generally useful

• File payloads/cbui/modules/cbfs_module.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 50: } __attribute__ ((packed));

    Prefer __packed over __attribute__((packed))

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 59: } __attribute__ ((packed));

    Prefer __packed over __attribute__((packed))

• File payloads/cbui/modules/cpuinfo_module.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 35: static const char *intel_cap_edx_flags[] = {

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 43: static const char *amd_cap_edx_flags[] = {

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 51: static const char *intel_cap_ecx_flags[] = {

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 59: static const char *amd_cap_ecx_flags[] = {

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 67: static const char *intel_cap_extended_edx_flags[] = {

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 75: static const char *intel_cap_extended_ecx_flags[] = {

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 83: static const char *amd_cap_extended_edx_flags[] = {

    static const char * array should probably be static const char * const

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159860):

    Patch Set #55, Line 92: static const char *amd_cap_extended_ecx_flags[] = {

    static const char * array should probably be static const char * const

To view, visit change 23586. To unsubscribe, or for help writing mail filters, visit settings.