build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 14:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@24 PS14, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@188 PS14, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@212 PS14, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@227 PS14, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@240 PS14, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@248 PS14, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@250 PS14, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@255 PS14, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@267 PS14, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@268 PS14, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@276 PS14, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@292 PS14, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@299 PS14, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@302 PS14, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@305 PS14, Line 305: floppy_verifier "michalos" "3e072552bcb39fffc4ed8c2e144cfecb6b98f90046e82a3690801a1bd3befcf9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@313 PS14, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@320 PS14, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@325 PS14, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@331 PS14, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@335 PS14, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@347 PS14, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@353 PS14, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@355 PS14, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@359 PS14, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@374 PS14, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@381 PS14, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@384 PS14, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@385 PS14, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@388 PS14, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@389 PS14, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@392 PS14, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@397 PS14, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@398 PS14, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@413 PS14, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@430 PS14, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@431 PS14, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@432 PS14, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@433 PS14, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@434 PS14, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@435 PS14, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@465 PS14, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@470 PS14, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@538 PS14, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@665 PS14, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@666 PS14, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@669 PS14, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@729 PS14, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@731 PS14, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@746 PS14, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@748 PS14, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@754 PS14, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@770 PS14, Line 770: csb_patcher "dgpu" "33874" "9" "f2c9c43" "2678af3d581fd11bc425baa10db3052ce21a925f87afae1b4c5416793e71135c" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@775 PS14, Line 775: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@780 PS14, Line 780: csb_patcher "tint" "33887" "2" "9c8151d" "6a389277d4d741ea09186f4fbb1960f0a39e40385192a3dadc244d1c590d5733" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@785 PS14, Line 785: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@790 PS14, Line 790: csb_patcher "cfgsb" "33885" "4" "bae2957" "1da3da1d963e6c39dcc210787102919cb72752ac51065e41a176adc2980bdcb1" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@795 PS14, Line 795: csb_patcher "config.lenovo_g505s" "32352" "21" "aa0fb53" "4187a0529aa61298ea0a4955f6781a9ca8387b47e5cd2864a68c0d60d51ceb13" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@800 PS14, Line 800: csb_patcher "config.asus_am1i-a" "33800" "8" "8cb58f0" "a305be7c5b0485cb1255e714253b3adb3c937d070d6d853e5881d48fb82bfe70" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@807 PS14, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@810 PS14, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@862 PS14, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@863 PS14, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@883 PS14, Line 883: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters