Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47104 )
Change subject: soc/intel/tigerlake: Add support to enable ISH FSP UPDs
......................................................................
Patch Set 1: Code-Review-1
This is not needed. the code is not added intentionally.
FSP setting is just do pin mux while pin mux while default values are not enabled(do not pin muxs).
So, ISH GP and ISH I2C are configured by pin mux by gpio.c.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ba05e9588ba2e75c9f49168568ff9850ab67abe
Gerrit-Change-Number: 47104
Gerrit-PatchSet: 1
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Nov 2020 01:29:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment