[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Support gpio eh and rsel setting for I2C

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30974 )

Change subject: mediatek/mt8183: Support gpio eh and rsel setting for I2C
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/30974/1/src/soc/mediatek/mt8183/gpio.c 
File src/soc/mediatek/mt8183/gpio.c:

https://review.coreboot.org/#/c/30974/1/src/soc/mediatek/mt8183/gpio.c@98 
PS1, Line 98: 	MTK_I2C_PIN_SPEC(PAD_SDA4_ID, 17, 12),
> By default settings must be reset, otherwise the low level of i2c is too high.

You didn't really answer my question. Are you saying that this must be done even to get lower frequencies than 3.4MHz working, or what?