Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 122:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35523/119/src/mainboard/acer/aspire... File src/mainboard/acer/aspire_vn7_572g/Kconfig:
https://review.coreboot.org/c/coreboot/+/35523/119/src/mainboard/acer/aspire... PS119, Line 13: # TODO: select DRIVERS_NVIDIA_OPTIMUS
Optimus support is implemented in CB:28380 and is not yet merged. […]
then rebase on CB:28380 or remove and add as a follow-up patch on top of CB:28380
https://review.coreboot.org/c/coreboot/+/35523/119/src/mainboard/acer/aspire... PS119, Line 75: #config TPM_PIRQ : # hex : # default 0x1e # GPP_A6_IRQ
Done
what's the consequence of enabling this on your board which lacks the TPM?
https://review.coreboot.org/c/coreboot/+/35523/119/src/mainboard/acer/aspire... File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35523/119/src/mainboard/acer/aspire... PS119, Line 140: # TODO: register "PcieRpAspm[9]" = "ASPM_L1" : # TODO: register "PcieRpL1Substates[9]" = "L1_SS_DISABLED"
This depends upon CB:39538. […]
either rebase on CB:39538 and remove the TODOs, or drop them and re-add in a follow-on patch that's based on CB:39538.