Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45828 )
Change subject: mb/intel/tglrvp: Enable Pcie WWAN m.2
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45828/3/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c:
https://review.coreboot.org/c/coreboot/+/45828/3/src/mainboard/intel/tglrvp/...
PS3, Line 102: PAD_CFG_GPO(GPP_C11, 1, PLTRST), /* FULL_CARD_POWER_OFF_N */
: PAD_CFG_GPO(GPP_C10, 1, PLTRST), /* WWAN_RST_N */
: PAD_CFG_GPO(GPP_B17, 1, PLTRST), /* WWAN_PERST_N */
: PAD_CFG_GPO(GPP_D15, 1, PLTRST), /* WWAN_DISABLE_N */
Can we use DEEP? We used DEEP for other configuration.
thanks we will check
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45828
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9b7915062b2ef65d881d478e64322c0b8765614
Gerrit-Change-Number: 45828
Gerrit-PatchSet: 3
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 30 Sep 2020 18:18:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-MessageType: comment