build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 55:
(67 comments)
File csb_patcher.sh:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/50ddfd22_c21d1004 PS55, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/cf502ab6_127eb823 PS55, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/a4b76215_79ee47bf PS55, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/16db4150_5dac3106 PS55, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/4007628d_79074db3 PS55, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/feb9a161_d318b8ec PS55, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/1e21e849_a6368e14 PS55, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/c396d16a_6d885976 PS55, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/f76b5a7a_b7de0432 PS55, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/2cd10dad_f042fd0e PS55, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/fecf81ac_ec71424e PS55, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/58ba9a12_7d73227b PS55, Line 295: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/9861ddcd_e1ecb73f PS55, Line 299: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}freedos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/90db2891_0e81d922 PS55, Line 303: floppy_verifier "freedos" "a8c771bfc8ecc4b338a442a3278715787055b5400aa00e0c51018955092a3c86" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/949df813_cd820438 PS55, Line 307: floppy_verifier "michalos" "9e063275a4b098a4af15fffbf6d0a8ae83d11470cb170809a38512eedc035843" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/03e5bae3_c069dff2 PS55, Line 315: floppy_verifier "fiwix" "c4f919adbb95bd145238e7543fe78f2703d87ee7d79e9b57f05b09a64aaa814f" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/94c20cb4_85485c9f PS55, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/69879ebf_63166d79 PS55, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/93218c8c_391b5c5f PS55, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/89f6b510_c3c42b8a PS55, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/3f319905_4fda5388 PS55, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/7a344b87_4578a4e1 PS55, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/b2f139b6_85ba9d18 PS55, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/42afcbad_d26e05f5 PS55, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/b2c1d9ac_dae3174d PS55, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/e2c9f702_b90ad836 PS55, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/318933c1_b002d9b7 PS55, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/93c7d6f9_0397f111 PS55, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/d0d579d9_3565be76 PS55, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/0c1e321d_0c5c7575 PS55, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/24df0587_ce1c80a3 PS55, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/90f37769_31b5f2cd PS55, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/99945da5_4a7ef9dd PS55, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/65c4ee2f_5621ce31 PS55, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/5ed6ecca_66b8c148 PS55, Line 429: csb_patcher "atombios" "58748" "1" "d825cb8" "9dccb185ddd02ee9d6406bc157d2f5a0beace30d1efe122828f9ad51a18569ff" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/f0bedee0_11cfff44 PS55, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/2d8f24c7_8da26655 PS55, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/0f481f4b_ff032734 PS55, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/4eb3d694_0b034909 PS55, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/08f7d823_1e8cbd83 PS55, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/98066bc6_4ebb3aa5 PS55, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/08e5fe4c_b67f33ea PS55, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/c302ed0c_aeb6e367 PS55, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/f10b9fc4_6e13268e PS55, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/3a629f26_b3c8da8a PS55, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/735d99ee_02f5cc6f PS55, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/b40d3c10_f7ecb1c5 PS55, Line 732: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/663ae3f9_55558103 PS55, Line 734: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/c4fbdd73_94b6fd7a PS55, Line 749: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/d2f121a9_01e61b75 PS55, Line 751: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/954d9556_9d0e0e9f PS55, Line 757: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/5640bbb6_36e8d330 PS55, Line 764: # Prints the currently-known errata: what you might need to do to ensure a stable coreboot build. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/cab856b7_1bd88173 PS55, Line 767: printf "\n ${bold}downgrade the GCC${bend} of a coreboot toolchain with three commands:\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/6e4fcd71_432e3258 PS55, Line 771: if yesno "This should be manually done before patching. ${bold}Continue patching?${bend}" "" ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/58a9d801_48cb3670 PS55, Line 787: csb_patcher "dgpu" "58745" "1" "d41dfa2" "107282101dbb021a5f24bc4bf6e0c0116f1e446b06ac8379cea6af2dae8cd398" "$1" "G505S " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/e622caae_0d878344 PS55, Line 792: csb_patcher "atombios" "58748" "1" "d825cb8" "9dccb185ddd02ee9d6406bc157d2f5a0beace30d1efe122828f9ad51a18569ff" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/eaa008a9_b865586a PS55, Line 797: csb_patcher "irq" "48427" "11" "8f2cdf1" "b82b7166377f81f16c8cebe54bb99b12efb12e3df6092a887773906196460340" "$1" "AMD good " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/626caa61_fab8373f PS55, Line 802: csb_patcher "seabios" "32351" "15" "c4fc787" "b15163a492215c3155e3029415bf07a4514d6c02dd393ad09148d2d4adc17657" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/e1a2821f_1c008d0e PS55, Line 807: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/44b12b36_e5379905 PS55, Line 812: csb_patcher "config.lenovo_g505s" "32352" "39" "c1f8e19" "4b8bb1cce5407035cd80286ca643678c2c0cf5bf3c51575d0ac960a666e0f8e2" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/329f18b0_c18f4cb4 PS55, Line 817: csb_patcher "config.asus_am1i-a" "33800" "26" "f84dd87" "d50768e47b997efe37d01dc772463f22f6d0c9c6d2e8b955e3d6d1f619421461" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/51ccb3a0_c9dde68d PS55, Line 822: csb_patcher "config.asus_a88xm-e" "39900" "13" "91a488a" "a198c56a91d08838b384c1cd9ee857ec81930159b6002093e42cb713f9b8ba9d" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/1fd34aa4_4a0c990b PS55, Line 829: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/6de72aca_a3e1462d PS55, Line 832: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/4de68d13_8502ad66 PS55, Line 887: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/af4f8c9e_31c297e3 PS55, Line 888: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/9a879e65_42b72835 PS55, Line 910: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters