Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36067 )
Change subject: mainboard/hatch/Kconfig: Add support for boot with tianocore payload ......................................................................
Patch Set 3: Code-Review-1
(5 comments)
https://review.coreboot.org/c/coreboot/+/36067/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36067/3//COMMIT_MSG@9 PS3, Line 9: Add new config Why?
https://review.coreboot.org/c/coreboot/+/36067/3//COMMIT_MSG@9 PS3, Line 9: Add new config and set the required GBB flags to support boot with : tianocore payload Please explain, why these GBB flags are required? Why can’t TianoCore be fixed?
https://review.coreboot.org/c/coreboot/+/36067/3//COMMIT_MSG@13 PS3, Line 13: tianocore TianoCore
What version? How can it be loaded from depthcharge?
https://review.coreboot.org/c/coreboot/+/36067/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/36067/3/src/mainboard/google/hatch/... PS3, Line 37: select GBB_FLAG_ENABLE_ALTERNATE_OS if BOARD_USES_TIANOCORE Why? What does the payload have to do with the OS?
https://review.coreboot.org/c/coreboot/+/36067/3/src/mainboard/google/hatch/... PS3, Line 46: select USE_ACPI_PM_TIMER I do not think, we want such a Kconfig option. The payload is user configurable, and there is already a Kconfig option, if TianoCore is selected as payload.