Patch set 3:Code-Review -1
5 comments:
Patch Set #3, Line 9: Add new config
Why?
Add new config and set the required GBB flags to support boot with
tianocore payload
Please explain, why these GBB flags are required? Why can’t TianoCore be fixed?
Patch Set #3, Line 13: tianocore
TianoCore
What version? How can it be loaded from depthcharge?
File src/mainboard/google/hatch/Kconfig:
Patch Set #3, Line 37: select GBB_FLAG_ENABLE_ALTERNATE_OS if BOARD_USES_TIANOCORE
Why? What does the payload have to do with the OS?
Patch Set #3, Line 46: select USE_ACPI_PM_TIMER
I do not think, we want such a Kconfig option. The payload is user configurable, and there is already a Kconfig option, if TianoCore is selected as payload.
To view, visit change 36067. To unsubscribe, or for help writing mail filters, visit settings.