Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46961 )
Change subject: drivers/usb/acpi: Add support for privacy_gpio ......................................................................
Patch Set 5: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... PS5, Line 22: int *curr_index
The caller doesn't seem to use the 'idx' parameter anywhere else, could it just be a static variable […]
No, because the chip driver can be used by multiple devices. And we want to ensure that the index count starts from 0 for each device.
https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... PS5, Line 67: 1 -1? Since that is used to skip adding the gpio to DSD.
https://review.coreboot.org/c/coreboot/+/46961/5/src/drivers/usb/acpi/usb_ac... PS5, Line 68: = 1 nit: not required since it is set before using.