Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38482 )
Change subject: mb/lenovo/x230: List Lenovo X230t convertible/tablet as variant ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38482/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38482/3//COMMIT_MSG@10 PS3, Line 10: CB:34361
It was said that hda_verb are the same for both boards: […]
Devicetree from CB:34361 has the following differences:
1. No wwan bits which is likely an error since x230t does have wwan support (according to the product page)
2. Different pcie_hotplug_map which could be an error as well.
3. register value for "eventb_enable" is diffferent for x230t. Don't know what it means.
https://review.coreboot.org/c/coreboot/+/38482/3/src/mainboard/lenovo/x230/K... File src/mainboard/lenovo/x230/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/38482/3/src/mainboard/lenovo/x230/K... PS3, Line 2: bool "ThinkPad X230 / X230t"
Note that the mainboard name (the one that appears in SMBIOS/DMI tables) is still "Thinkpad X230" fo […]
Done. Changed MAINBOARD_PART_NUMBER in case of x230t.