Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37544 )
Change subject: mb/google/hatch/var/akemi: Tune Goodix touch screen reset delay time to 150ms
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37544/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37544/2//COMMIT_MSG@7
PS2, Line 7: mb/google/hatch/var/akemi: Tune Goodix touch screen
: reset delay time to 150ms
Please use only one-line git commit message summaries.
Maybe:
mb/google/hatch/variant/akemi: Increase Goodix touch screen reset delay time
https://review.coreboot.org/c/coreboot/+/37544/2//COMMIT_MSG@10
PS2, Line 10: change
increase
https://review.coreboot.org/c/coreboot/+/37544/2//COMMIT_MSG@11
PS2, Line 11: from 120ms to 150ms
Please add a period/dot to the end of sentences.
What problem does this fix? When is the touch screen not working?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37544
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ff95ac89314fc031620ca28e4f6e6e26cdef3f9
Gerrit-Change-Number: 37544
Gerrit-PatchSet: 2
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wuxy -
wuxy@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Dec 2019 12:53:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment