Change in coreboot[master]: mb/google/hatch/var/akemi: Tune Goodix touch screen reset delay time ...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Peichao Li (Code Review)

6 Dec 2019 6 Dec '19

3:39 a.m.

Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37544 )

Change subject: mb/google/hatch/var/akemi: Tune Goodix touch screen reset delay time to 150ms ......................................................................

mb/google/hatch/var/akemi: Tune Goodix touch screen reset delay time to 150ms

Confirmed with Goodix engineer and Google team, so change reset delay time from 120ms to 150ms

BUG=b:144267684 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage

Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I4ff95ac89314fc031620ca28e4f6e6e26cdef3f9 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/37544/1

diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb index da669e4..de4a903 100644 --- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb +++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb @@ -205,7 +205,7 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "120" + register "generic.reset_delay_ms" = "150" register "generic.reset_off_delay_ms" = "3" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Peichao Li (Code Review)

6 Dec 6 Dec

3:46 a.m.

Hello Xingyu Wu, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh, Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37544

to look at the new patch set (#2).

Change subject: mb/google/hatch/var/akemi: Tune Goodix touch screen reset delay time to 150ms ......................................................................

mb/google/hatch/var/akemi: Tune Goodix touch screen reset delay time to 150ms

Confirmed with Goodix team, so change reset delay time from 120ms to 150ms

BUG=b:144267684 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/37544/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ff95ac89314fc031620ca28e4f6e6e26cdef3f9 Gerrit-Change-Number: 37544 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Xingyu Wu wuxy@bitland.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Philip Chen (Code Review)

10:31 a.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37544 )

Change subject: mb/google/hatch/var/akemi: Tune Goodix touch screen reset delay time to 150ms ......................................................................

Patch Set 2:

The latest Goodix datasheet says a reset delay of 120ms is enough. If this is not true, shouldn't it be fixed in Goodix FW? Or Goodix has to update the datasheet.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ff95ac89314fc031620ca28e4f6e6e26cdef3f9 Gerrit-Change-Number: 37544 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Xingyu Wu wuxy@bitland.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 06 Dec 2019 09:31:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Wuxy - (Code Review)

10:44 a.m.

Wuxy - has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37544 )

Change subject: mb/google/hatch/var/akemi: Tune Goodix touch screen reset delay time to 150ms ......................................................................

Patch Set 2:

Hi Philip, 120ms is the SPEC requirement,this issue can also be covered by new FW now,and Goodix will update the new FW for this next DVT phase, but Goodix recommends that 150ms will be a better value to avoid any issue.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ff95ac89314fc031620ca28e4f6e6e26cdef3f9 Gerrit-Change-Number: 37544 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Wuxy - wuxy@bitland.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 06 Dec 2019 09:44:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

1:53 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37544 )

Change subject: mb/google/hatch/var/akemi: Tune Goodix touch screen reset delay time to 150ms ......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/c/coreboot/+/37544/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37544/2//COMMIT_MSG@7 PS2, Line 7: mb/google/hatch/var/akemi: Tune Goodix touch screen : reset delay time to 150ms Please use only one-line git commit message summaries.

Maybe:

...

mb/google/hatch/variant/akemi: Increase Goodix touch screen reset delay time

https://review.coreboot.org/c/coreboot/+/37544/2//COMMIT_MSG@10 PS2, Line 10: change increase

https://review.coreboot.org/c/coreboot/+/37544/2//COMMIT_MSG@11 PS2, Line 11: from 120ms to 150ms Please add a period/dot to the end of sentences.

What problem does this fix? When is the touch screen not working?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ff95ac89314fc031620ca28e4f6e6e26cdef3f9 Gerrit-Change-Number: 37544 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Wuxy - wuxy@bitland.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 06 Dec 2019 12:53:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Wuxy - (Code Review)

10 Dec 10 Dec

7:48 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/variant/akemi: Increase Goodix touch screen reset del...

Wuxy - has uploaded a new patch set (#3) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/37544 )

Change subject: mb/google/hatch/variant/akemi: Increase Goodix touch screen reset delay time ......................................................................

mb/google/hatch/variant/akemi: Increase Goodix touch screen reset delay time

Confirmed with Goodix team, so increase reset delay time from 120ms to 150ms.

BUG=b:144267684 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/37544/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ff95ac89314fc031620ca28e4f6e6e26cdef3f9 Gerrit-Change-Number: 37544 Gerrit-PatchSet: 3 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Wuxy - wuxy@bitland.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

11 Dec 11 Dec

9:14 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/variant/akemi: Increase Goodix touch screen reset del...

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37544 )

Change subject: mb/google/hatch/variant/akemi: Increase Goodix touch screen reset delay time ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ff95ac89314fc031620ca28e4f6e6e26cdef3f9 Gerrit-Change-Number: 37544 Gerrit-PatchSet: 3 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Wuxy - wuxy@bitland.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Dec 2019 20:14:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Peichao Li (Code Review)

12 Dec 12 Dec

6:44 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/variant/akemi: Increase Goodix touch screen reset del...

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37544 )

Change subject: mb/google/hatch/variant/akemi: Increase Goodix touch screen reset delay time ......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/37544/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37544/2//COMMIT_MSG@7 PS2, Line 7: mb/google/hatch/var/akemi: Tune Goodix touch screen : reset delay time to 150ms

...

Please use only one-line git commit message summaries. […]

Done

https://review.coreboot.org/c/coreboot/+/37544/2//COMMIT_MSG@10 PS2, Line 10: change

...

increase

Done

https://review.coreboot.org/c/coreboot/+/37544/2//COMMIT_MSG@11 PS2, Line 11: from 120ms to 150ms

...

Please add a period/dot to the end of sentences. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/37544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ff95ac89314fc031620ca28e4f6e6e26cdef3f9 Gerrit-Change-Number: 37544 Gerrit-PatchSet: 3 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Wuxy - wuxy@bitland.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 12 Dec 2019 05:44:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:11 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/variant/akemi: Increase Goodix touch screen reset del...

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37544 )

Change subject: mb/google/hatch/variant/akemi: Increase Goodix touch screen reset delay time ......................................................................

mb/google/hatch/variant/akemi: Increase Goodix touch screen reset delay time

Confirmed with Goodix team, so increase reset delay time from 120ms to 150ms.

BUG=b:144267684 TEST=FW_NAME="akemi" emerge-hatch coreboot chromeos-ec chromeos-bootimage

Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I4ff95ac89314fc031620ca28e4f6e6e26cdef3f9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/37544 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/37544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ff95ac89314fc031620ca28e4f6e6e26cdef3f9 Gerrit-Change-Number: 37544 Gerrit-PatchSet: 4 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Wuxy - wuxy@bitland.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1611

days inactive

1617

days old

coreboot-gerrit@coreboot.org

8 comments

6 participants

tags (0)

participants (6)

Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Peichao Li (Code Review)
Philip Chen (Code Review)
Tim Wawrzynczak (Code Review)
Wuxy - (Code Review)