Attention is currently required from: Tristan Corrick, Angel Pons, Arthur Heymans. Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30890 )
Change subject: autoport: Add support for Haswell-LynxPoint platform ......................................................................
Patch Set 30:
(13 comments)
File util/autoport/haswell.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/c235ed1d_89ef66a6 PS13, Line 13: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP,
Do we need this?
removed
File util/autoport/haswell.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/678b22ba_49d1162f PS22, Line 12: */
This should have a space
Done
https://review.coreboot.org/c/coreboot/+/30890/comment/610a36bf_b2e5da42 PS22, Line 50: dq_pins_interleaved
Only matters for ULT. You can derive this from the DDR_SCRAM_MISC_CONTROL register: […]
Done
https://review.coreboot.org/c/coreboot/+/30890/comment/e3e2165d_631a3150 PS22, Line 74: /* FIXME:XX hardcoded. */ : "c1_acpower": cstate[0], : "c2_acpower": cstate[1], : "c3_acpower": cstate[2], : "c1_battery": cstate[0], : "c2_battery": cstate[1], : "c3_battery": cstate[2],
We no longer have C-states in the devicetree for Haswell.
Done
File util/autoport/haswell.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/c091c94b_727eb7d2 PS23, Line 18: */
nit: comment end should have a space before
Done
File util/autoport/haswell.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/f9596141_48937b60 PS25, Line 150: RegisterPCI(0x8086, 0x0c0c, GenericPCI{})
0x0a0c missing
Done
File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/2a31a665_2e009654 PS13, Line 585: /* SDIO */ : RegisterPCI(0x8086, 0x9c35, GenericPCI{}) : : /* Smart Sound Technology Controller */ : RegisterPCI(0x8086, 0x9c36, GenericPCI{}) : : /* Serial I/O */ : for id := uint16(0x9c60); id <= 0x9c66; id++ { : RegisterPCI(0x8086, id, GenericPCI{}) : }
These don't exist on non-LP.
This code is only used to register the device IDs to autoport.
File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/ecaf59e1_b617f06c PS22, Line 249: /* Shared with ME. Flashrom is unable to handle it. */ : FlashROMSupport = "n"
No longer true.
Done
https://review.coreboot.org/c/coreboot/+/30890/comment/618b4866_671d8ccd PS22, Line 593: gnvs := Create(ctx, "acpi_tables.c")
I would not generate this file at all.
removed
File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/07cff6e0_8cae181f PS23, Line 249: /* Shared with ME. Flashrom is unable to handle it. */
Untrue
Done
https://review.coreboot.org/c/coreboot/+/30890/comment/3b61be52_d9aa3168 PS23, Line 393: void mainboard_config_superio(void)
It's optional
Ack
https://review.coreboot.org/c/coreboot/+/30890/comment/c476d79d_06202414 PS23, Line 604: gnvs->tpsv = 90;
Most often, this is dead code.
removed
File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/43d8e196_d0c596d5 PS25, Line 298: KconfigInt["USBDEBUG_HCD_INDEX"] = 2
On LPT-LP, this should be 1
Done