Attention is currently required from: Tristan Corrick, Angel Pons, Arthur Heymans.
13 comments:
File util/autoport/haswell.go:
Patch Set #13, Line 13: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP,
Do we need this?
removed
File util/autoport/haswell.go:
This should have a space
Done
Patch Set #22, Line 50: dq_pins_interleaved
Only matters for ULT. You can derive this from the DDR_SCRAM_MISC_CONTROL register: […]
Done
/* FIXME:XX hardcoded. */
"c1_acpower": cstate[0],
"c2_acpower": cstate[1],
"c3_acpower": cstate[2],
"c1_battery": cstate[0],
"c2_battery": cstate[1],
"c3_battery": cstate[2],
We no longer have C-states in the devicetree for Haswell.
Done
File util/autoport/haswell.go:
nit: comment end should have a space before
Done
File util/autoport/haswell.go:
Patch Set #25, Line 150: RegisterPCI(0x8086, 0x0c0c, GenericPCI{})
0x0a0c missing
Done
File util/autoport/lynxpoint.go:
/* SDIO */
RegisterPCI(0x8086, 0x9c35, GenericPCI{})
/* Smart Sound Technology Controller */
RegisterPCI(0x8086, 0x9c36, GenericPCI{})
/* Serial I/O */
for id := uint16(0x9c60); id <= 0x9c66; id++ {
RegisterPCI(0x8086, id, GenericPCI{})
}
These don't exist on non-LP.
This code is only used to register the device IDs to autoport.
File util/autoport/lynxpoint.go:
/* Shared with ME. Flashrom is unable to handle it. */
FlashROMSupport = "n"
No longer true.
Done
Patch Set #22, Line 593: gnvs := Create(ctx, "acpi_tables.c")
I would not generate this file at all.
removed
File util/autoport/lynxpoint.go:
Patch Set #23, Line 249: /* Shared with ME. Flashrom is unable to handle it. */
Untrue
Done
Patch Set #23, Line 393: void mainboard_config_superio(void)
It's optional
Ack
Patch Set #23, Line 604: gnvs->tpsv = 90;
Most often, this is dead code.
removed
File util/autoport/lynxpoint.go:
Patch Set #25, Line 298: KconfigInt["USBDEBUG_HCD_INDEX"] = 2
On LPT-LP, this should be 1
Done
To view, visit change 30890. To unsubscribe, or for help writing mail filters, visit settings.