[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Set FSP-S Enable8254ClockGating using clock_gat...

[Jeremy Soller (Code Review)]

Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31534 )

Change subject: soc/intel/cannonlake: Set FSP-S Enable8254ClockGating using clock_gate_8254 devicetree parameter
......................................................................

Patch Set 2:
> Patch Set 1:
>
> (1 comment)

So, there are three cases identified in the FSP documentation. I think I will make this an enum like so:

{
  OFF, // There is no 8254 clock gating
  S3, // 8254 clock gating happens in S3
  ON, // 8254 clock gating happens on boot and in S3
}