Patch Set 1:

(1 comment)

So, there are three cases identified in the FSP documentation. I think I will make this an enum like so:

{
OFF, // There is no 8254 clock gating
S3, // 8254 clock gating happens in S3
ON, // 8254 clock gating happens on boot and in S3
}

View Change

To view, visit change 31534. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id346173ac7ae5246de0b38b9dd23be7b72e70f1e
Gerrit-Change-Number: 31534
Gerrit-PatchSet: 2
Gerrit-Owner: Jeremy Soller <jackpot51@gmail.com>
Gerrit-Reviewer: Jeremy Soller <jackpot51@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Lijian Zhao <lijian.zhao@intel.com>
Gerrit-CC: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:36:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment