Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33621 )
Change subject: soc/amd/stoneyridge: Add merlinfalcon configuration ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33621/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33621/5//COMMIT_MSG@9 PS5, Line 9: In preparation to add board padmelon, There's no reason to talk about preparing for a board. Instead, make your commit message more descriptive about Merlin Falcon.
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... PS5, Line 33: bool
Never did a prompt, so was not aware I could. Will investigate how.
Look at line 202.
It seems that something like a symbol name of HAVE_MERLINFALCON_BINARIES would better match other coreboot Kconfig files.
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... PS5, Line 347: <codename>
Not sure, we are already at soc/stoneyridge. Maybe something like: […]
You forgot to address this comment https://review.coreboot.org/c/coreboot/+/33621/3/src/soc/amd/stoneyridge/Kco...
Perhaps simply make this depends on SOC_AMD_STONEYRIDGE instead of defaulting to a value for MF. (I believe that should work cleanly.)
https://review.coreboot.org/c/coreboot/+/33621/3/src/soc/amd/stoneyridge/Mak... File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33621/3/src/soc/amd/stoneyridge/Mak... PS3, Line 204: endif
I tried, unfortunately no. It would require dummy *_FN images, otherwise build fails.
Can you try again please? I tried it before I suggested it to you, and it still builds OK on my side when I test w/Grunt by deleting the ST fanless files.