Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 157:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35523/145/src/mainboard/acer/aspire... File src/mainboard/acer/aspire_vn7_572g/cmos.layout:
https://review.coreboot.org/c/coreboot/+/35523/145/src/mainboard/acer/aspire... PS145, Line 36: #1024 1024 r 0 upper_reserved
Should I drop it?
Dropped.
https://review.coreboot.org/c/coreboot/+/35523/145/src/mainboard/acer/aspire... File src/mainboard/acer/aspire_vn7_572g/gpio.h:
https://review.coreboot.org/c/coreboot/+/35523/145/src/mainboard/acer/aspire... PS145, Line 259: PAD_CFG_GPIO_BIDIRECT(GPP_E22, 0, NONE, DEEP, LEVEL, ACPI),
The vendor firmware has a configuration option called "bidirectional PROCHOT#," which defaults to en […]
I moved the macro into gpio.h so that it will build and to preserve the old behaviour, but I'll look into why an apparently disconnected GPIO is being programmed as bidirectional.