ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30554 )
Change subject: WIP: mb/qemu-riscv: update to match current qemu version
......................................................................
Patch Set 3:
(1 comment)
If you can fix this include I think this is fine.
https://review.coreboot.org/#/c/30554/3/src/mainboard/emulation/qemu-riscv/c...
File src/mainboard/emulation/qemu-riscv/clint.c:
https://review.coreboot.org/#/c/30554/3/src/mainboard/emulation/qemu-riscv/c...
PS3, Line 23: HLS()->time = (uint64_t *)(QEMU_VIRT_CLINT + 0xbff8);
that's not common for coreboot […]
it's a regrettable riscv convention but I think we should accept it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30554
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie107eb882cbaac5a5a06c1ff990e7b9364377640
Gerrit-Change-Number: 30554
Gerrit-PatchSet: 3
Gerrit-Owner: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 25 Jan 2019 22:48:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment