Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30767 )
Change subject: mb/asus/h61m-cs: Add ASUS H61M-CS ......................................................................
Patch Set 12:
(1 comment)
Patch Set 12:
Patch Set 12:
Patch Set 12:
More info on the USB keyboard issue.
A cold boot does not init the usb keyboard in time. On the GRUB menu if I physically restart the machine by pressing the restart button the keyboard starts working again. This happens on all the USB ports.
So the issue is not related to specific USB ports, but rather cold boot/warm boot differences? I would try comparing logs.
The logs don't different to me. I tried using another usb keyboard without a hub. It worked. It was directly connected to the rear usb port. I added another hub between and it worked. It stopped working when I added a second hub. I think its because of these hubs and they are taking some time to initialize. By the time it has init the PC is already at the grub menu.
cbmem log, keyb on hub: https://pastebin.com/sznRZWCj cbmem log, keyb connected directly: https://pastebin.com/yuwAWVGt
That's good to know. I've also had issues on bd82x6x boards using a keyboard that has a hub. Though, the same keyboard worked on a Lynx Point board. The issue might be in the southbridge code, not the board- specific code.
https://review.coreboot.org/#/c/30767/12/src/mainboard/asus/h61m-cs/devicetr... File src/mainboard/asus/h61m-cs/devicetree.cb:
https://review.coreboot.org/#/c/30767/12/src/mainboard/asus/h61m-cs/devicetr... PS12, Line 51: on end # PCIe x1 Slot 2
What is 1c. […]
If you add a card in to the other x1 PCIe slot, and nothing shows up under it in lspci, then it's not used on the board and should be set to `off`. Enabled root ports still show up under lspci even when they aren't used.