Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40061 )
Change subject: soc/intel/tigerlake: update memory cfg for Tiger Lake
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40061/1/src/soc/intel/tigerlake/mem...
File src/soc/intel/tigerlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/40061/1/src/soc/intel/tigerlake/mem...
PS1, Line 43: mem_cfg->Reserved9[channel] = get_dimm_cfg(spd_dimm0, spd_dimm1);
With this CL being merged https://review.coreboot.org/c/coreboot/+/39797.. we were hitting array out of bound since Reserved9 is only 2 elements now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40061
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0b5783a8bef02ec8c265fa5b47ce532a77b9675
Gerrit-Change-Number: 40061
Gerrit-PatchSet: 1
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Thu, 02 Apr 2020 22:52:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment