27 Jan
2019
27 Jan
'19
5:23 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30767 )
Change subject: mb/asus/h61m-cs: Add ASUS H61M-CS ......................................................................
Patch Set 14: Code-Review+1
(1 comment)
Looks good, waiting on the SATA port test to +2
https://review.coreboot.org/#/c/30767/14/src/mainboard/asus/h61m-cs/devicetr... File src/mainboard/asus/h61m-cs/devicetree.cb:
https://review.coreboot.org/#/c/30767/14/src/mainboard/asus/h61m-cs/devicetr... PS14, Line 38: 0x13
Hmm. Actually I have only 3 SATA HDDs on the mainboard and 2 on the expansion board. […]
Is this value needed or can it be dropped?
--
To view, visit https://review.coreboot.org/c/coreboot/+/30767
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ed2077248a8d7123c728c790d9b81fe37956ed2
Gerrit-Change-Number: 30767
Gerrit-PatchSet: 14
Gerrit-Owner: Dev Master realdevmaster64@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Dev Master realdevmaster64@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 27 Jan 2019 08:23:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tristan Corrick tristan@corrick.kiwi
Comment-In-Reply-To: Dev Master realdevmaster64@gmail.com
Gerrit-MessageType: comment