6 Jan
2021
6 Jan
'21
3:02 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49136 )
Change subject: mb/intel/adlrvp: Fix wrong comments and typo ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49136/2/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49136/2/src/mainboard/intel/adlrvp/... PS2, Line 74: Enable CPU PCIE PEG Slot 1 and 2 But, you are not setting CpuPcieRpEnableMask for ports 1 and 2. Do these configurations for PcieClkSrcUsage actually do anything at all?
--
To view, visit https://review.coreboot.org/c/coreboot/+/49136
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92123450bd7cfb2e70aae8de03053672a7772451
Gerrit-Change-Number: 49136
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 06 Jan 2021 22:02:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment