Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48520 )
Change subject: src/lib: Add Kconfig option for SPD cache in FMAP ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig File src/lib/Kconfig:
https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig@57 PS1, Line 57: _IN_FMAP Do we need the _IN_FMAP part? Also, should SODIMM be in the name? SODIMM_SPD_CACHE?
https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig@62 PS1, Line 62: board-level implementation I think this should be something that a common library or SoC code handles. Anyways, it is out of scope for this CL.
https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig@64 PS1, Line 64: RW_SPD_CACHE Just a note: Since the default is being set to RW_SPD_CACHE, any board using this in their own custom fmd file will also have to use the same name.