Patch set 1:Code-Review +2
View Change
3 comments:
File src/lib/Kconfig:
Patch Set #1, Line 57: _IN_FMAP
Do we need the _IN_FMAP part? Also, should SODIMM be in the name? SODIMM_SPD_CACHE?
Patch Set #1, Line 62: board-level implementation
I think this should be something that a common library or SoC code handles. Anyways, it is out of scope for this CL.
Patch Set #1, Line 64: RW_SPD_CACHE
Just a note: Since the default is being set to RW_SPD_CACHE, any board using this in their own custom fmd file will also have to use the same name.
To view, visit change 48520. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee0e7acb01e238d7ed354e3dbab1207903e3a4fc
Gerrit-Change-Number: 48520
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Jamie Chen <jamie.chen@intel.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 10 Dec 2020 02:03:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment