[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: Support gpio eh and rsel setting for I2C

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30974 )

Change subject: mediatek/mt8183: Support gpio eh and rsel setting for I2C
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/30974/1/src/soc/mediatek/mt8183/gpio.c 
File src/soc/mediatek/mt8183/gpio.c:

https://review.coreboot.org/#/c/30974/1/src/soc/mediatek/mt8183/gpio.c@98 
PS1, Line 98: 	MTK_I2C_PIN_SPEC(PAD_SDA4_ID, 17, 12),
> These pins are for specific adjustment of AC-timing in order to satisfy the i2c spec(3.4MHz). […]

What I2C device are you driving at more than 1MHz in firmware? Note that if this is only necessary for devices that will only be used by the kernel, the kernel should do this initialization. The firmware should only initialize devices it actually needs to use itself.