build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31233 )
Change subject: soc/amd: Add Merlin Falcon soc code ......................................................................
Patch Set 1:
(20 comments)
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/bootblock/b... File src/soc/amd/merlinfalcon/bootblock/bootblock.c:
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/bootblock/b... PS1, Line 83: void (*ap_romstage_entry)(void) = function definition argument 'void' should also have an identifier name
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/imc.c File src/soc/amd/merlinfalcon/imc.c:
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/imc.c@75 PS1, Line 75: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/imc.c@77 PS1, Line 77: return (bool) (((Flag >> (func *4)) & 0xF) & ((UINT8 )1 << Zone)); need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/imc.c@77 PS1, Line 77: return (bool) (((Flag >> (func *4)) & 0xF) & ((UINT8 )1 << Zone)); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/imc.c@120 PS1, Line 120: if ( Msgdata == 0xfa) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/imc.c@190 PS1, Line 190: if (!IsImcEnabled ()) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/imc.c@196 PS1, Line 196: for ( FunIndex = 1; FunIndex <= 3; FunIndex++ ) { space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/imc.c@196 PS1, Line 196: for ( FunIndex = 1; FunIndex <= 3; FunIndex++ ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/imc.c@198 PS1, Line 198: for (ZoneNum = 0; ZoneNum < MaxZone[FunIndex]; ZoneNum++ ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/imc.c@256 PS1, Line 256: if (!(IsImcEnabled ())) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/include/soc... File src/soc/amd/merlinfalcon/include/soc/southbridge.h:
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/include/soc... PS1, Line 343: #define SPI_READ_MODE_DUAL112 ( BIT(29) ) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/include/soc... PS1, Line 343: #define SPI_READ_MODE_DUAL112 ( BIT(29) ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/include/soc... PS1, Line 344: #define SPI_READ_MODE_QUAD114 ( BIT(29) | BIT(18)) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/include/soc... PS1, Line 345: #define SPI_READ_MODE_DUAL122 (BIT(30) ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/include/soc... PS1, Line 347: #define SPI_READ_MODE_NORMAL66 (BIT(30) | BIT(29) ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/include/soc... PS1, Line 374: #define SPI_SPEED_33M ( BIT(0)) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/include/soc... PS1, Line 375: #define SPI_SPEED_22M ( BIT(1) ) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/include/soc... PS1, Line 375: #define SPI_SPEED_22M ( BIT(1) ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/include/soc... PS1, Line 376: #define SPI_SPEED_16M ( BIT(1) | BIT(0)) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/31233/1/src/soc/amd/merlinfalcon/include/soc... PS1, Line 377: #define SPI_SPEED_100M (BIT(2) ) space prohibited before that close parenthesis ')'