View Change

20 comments:

• File src/soc/amd/merlinfalcon/bootblock/bootblock.c:

  • Patch Set #1, Line 83: void (*ap_romstage_entry)(void) =

    function definition argument 'void' should also have an identifier name

• File src/soc/amd/merlinfalcon/imc.c:

  • Patch Set #1, Line 75: )

    please, no spaces at the start of a line

  • Patch Set #1, Line 77: return (bool) (((Flag >> (func *4)) & 0xF) & ((UINT8 )1 << Zone));

    need consistent spacing around '*' (ctx:WxV)

  • Patch Set #1, Line 77: return (bool) (((Flag >> (func *4)) & 0xF) & ((UINT8 )1 << Zone));

    space prohibited before that close parenthesis ')'

  • Patch Set #1, Line 120: if ( Msgdata == 0xfa)

    space prohibited after that open parenthesis '('

  • Patch Set #1, Line 190: if (!IsImcEnabled ())

    space prohibited between function name and open parenthesis '('

  • Patch Set #1, Line 196: for ( FunIndex = 1; FunIndex <= 3; FunIndex++ ) {

    space prohibited after that open parenthesis '('

  • Patch Set #1, Line 196: for ( FunIndex = 1; FunIndex <= 3; FunIndex++ ) {

    space prohibited before that close parenthesis ')'

  • Patch Set #1, Line 198: for (ZoneNum = 0; ZoneNum < MaxZone[FunIndex]; ZoneNum++ ) {

    space prohibited before that close parenthesis ')'

  • Patch Set #1, Line 256: if (!(IsImcEnabled ()))

    space prohibited between function name and open parenthesis '('

• File src/soc/amd/merlinfalcon/include/soc/southbridge.h:

  • Patch Set #1, Line 343: #define SPI_READ_MODE_DUAL112 ( BIT(29) )

    space prohibited after that open parenthesis '('

  • Patch Set #1, Line 343: #define SPI_READ_MODE_DUAL112 ( BIT(29) )

    space prohibited before that close parenthesis ')'

  • Patch Set #1, Line 344: #define SPI_READ_MODE_QUAD114 ( BIT(29) | BIT(18))

    space prohibited after that open parenthesis '('

  • Patch Set #1, Line 345: #define SPI_READ_MODE_DUAL122 (BIT(30) )

    space prohibited before that close parenthesis ')'

  • Patch Set #1, Line 347: #define SPI_READ_MODE_NORMAL66 (BIT(30) | BIT(29) )

    space prohibited before that close parenthesis ')'

  • Patch Set #1, Line 374: #define SPI_SPEED_33M ( BIT(0))

    space prohibited after that open parenthesis '('

  • Patch Set #1, Line 375: #define SPI_SPEED_22M ( BIT(1) )

    space prohibited after that open parenthesis '('

  • Patch Set #1, Line 375: #define SPI_SPEED_22M ( BIT(1) )

    space prohibited before that close parenthesis ')'

  • Patch Set #1, Line 376: #define SPI_SPEED_16M ( BIT(1) | BIT(0))

    space prohibited after that open parenthesis '('

  • Patch Set #1, Line 377: #define SPI_SPEED_100M (BIT(2) )

    space prohibited before that close parenthesis ')'

To view, visit change 31233. To unsubscribe, or for help writing mail filters, visit settings.