Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36452 )
Change subject: hatch: Create puff variant ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36452/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/gpio.c:
https://review.coreboot.org/c/coreboot/+/36452/4/src/mainboard/google/hatch/... PS4, Line 41: /* E23 : TP1 */ : PAD_NC(GPP_E23, NONE), : /* H17 : TP2 */ : PAD_NC(GPP_H17, NONE),
That's right. In general, early_gpio_table[] is used to configure any pads that are: […]
Ack
https://review.coreboot.org/c/coreboot/+/36452/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/36452/4/src/mainboard/google/hatch/... PS4, Line 47: .rise_time_ns = 0, : .fall_time_ns = 0,
Okay. SG.
Ack
https://review.coreboot.org/c/coreboot/+/36452/4/src/mainboard/google/hatch/... PS4, Line 76: chip drivers/i2c/generic
nit: You can just remove it and add it when really required. Upto you.
Ack, I'll leave for now until I see the thing boot and include dealing with this as part of the clean ups.