3 comments:
File src/mainboard/google/hatch/variants/puff/gpio.c:
/* E23 : TP1 */
PAD_NC(GPP_E23, NONE),
/* H17 : TP2 */
PAD_NC(GPP_H17, NONE),
That's right. In general, early_gpio_table[] is used to configure any pads that are: […]
Ack
File src/mainboard/google/hatch/variants/puff/overridetree.cb:
.rise_time_ns = 0,
.fall_time_ns = 0,
Okay. SG.
Ack
Patch Set #4, Line 76: chip drivers/i2c/generic
nit: You can just remove it and add it when really required. Upto you.
Ack, I'll leave for now until I see the thing boot and include dealing with this as part of the clean ups.
To view, visit change 36452. To unsubscribe, or for help writing mail filters, visit settings.