Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33621 )
Change subject: soc/amd/stoneyridge: Add Merlin Falcon configuration ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33621/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33621/6//COMMIT_MSG@10 PS6, Line 10: makefile
modify THE makefile
Ok, will do.
https://review.coreboot.org/c/coreboot/+/33621/6/src/soc/amd/stoneyridge/Kco... File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/33621/6/src/soc/amd/stoneyridge/Kco... PS6, Line 33: bool
Here's how you add the prompt: […]
Thanks, will do.
https://review.coreboot.org/c/coreboot/+/33621/6/src/soc/amd/stoneyridge/Kco... PS6, Line 327: bool
Add a prompt here? Otherwise it will always be y for stoney and N for merlin falcon unless overridd […]
It must always be N for Merlin Falcon. and it was originally selected (thus "Y") for Stoney Ridge. So even before, if a board wanted it to be no then it had to be overridden by mainboard. I think this is fine as is.
https://review.coreboot.org/c/coreboot/+/33621/6/src/soc/amd/stoneyridge/Mak... File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33621/6/src/soc/amd/stoneyridge/Mak... PS6, Line 197: : ifeq ("$(wildcard $(SMUFWM_FN_FILE))","")
Don't you want a build failure if the user wanted to include the file but doesn't have them in the r […]
No, what I'm doing here is to avoid a much more complicated workaround for Merlin Falcon. Without this change, the Merlin Falcon PSP would need fake _FN.sbin files to avoid a build failure. Merlin Falcon don't have _FN versions for PSP. This solution was suggested by Marshall, replacing a much more complex solution I had before.