Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8 ......................................................................
Patch Set 27: Code-Review+1
(5 comments)
Boot log looks good: https://0paste.com/32642
I didn't try booting a payload.
https://review.coreboot.org/c/coreboot/+/33387/27//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33387/27//COMMIT_MSG@9 PS27, Line 9: "adds a new board"
https://review.coreboot.org/c/coreboot/+/33387/27/Documentation/mainboard/em... File Documentation/mainboard/emulation/qemu-aarch64.md:
https://review.coreboot.org/c/coreboot/+/33387/27/Documentation/mainboard/em... PS27, Line 37: an
https://review.coreboot.org/c/coreboot/+/33387/27/Documentation/mainboard/em... PS27, Line 37: an
https://review.coreboot.org/c/coreboot/+/33387/27/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/cbmem.c:
https://review.coreboot.org/c/coreboot/+/33387/27/src/mainboard/emulation/qe... PS27, Line 49: 1 Is this arbitrary?
https://review.coreboot.org/c/coreboot/+/33387/27/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33387/27/src/mainboard/emulation/qe... PS27, Line 8: Add a comment saying that the only reason this is here is to keep the compiler happy.