Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46090 )
Change subject: mb/google/dedede: refactor DPTF section for simpler overrides ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46090/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46090/2/src/mainboard/google/dedede... PS2, Line 102: .pl2 = { : .min_power = 6000, : .max_power = 20000, : .time_window_min = 1 * MSECS_PER_SEC, : .time_window_max = 1 * MSECS_PER_SEC, : .granularity = 1000, : }
As per my observations, we need pl2 entries here otherwise it's taking zeros for these entries. […]
If you wanted, you could separate out pl1 and pl2 in the override tree like so: ``` register "controls.power_limits.pl1" = "{ .min_power = 4800, ... }," register "controls.power_limits.pl2" = "{ .min_power = 6000, ... }," ```
that way each of them can be individually overridden (or not) in the override trees. Right now, you have to specify either both or none (and take the baseboard default). Up to you.