Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34299 )
Change subject: soc/intel: Use config_of_path(SA_DEVFN_ROOT) ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34299/4/src/soc/intel/apollolake/ac... File src/soc/intel/apollolake/acpi.c:
https://review.coreboot.org/c/coreboot/+/34299/4/src/soc/intel/apollolake/ac... PS4, Line 172: cfg If cfg was NULL, control would never reach here.
https://review.coreboot.org/c/coreboot/+/34299/4/src/soc/intel/apollolake/ch... File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/c/coreboot/+/34299/4/src/soc/intel/apollolake/ch... PS4, Line 677: if (!dev || !cfg) If cfg or dev is NULL, control would never reach here.