Attention is currently required from: Jakub Czapiga.
Hello build bot (Jenkins), Martin L Roth, Daniel Gröber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42117
to look at the new patch set (#26).
Change subject: spi/winbond: Add a test for block protection status bits ......................................................................
spi/winbond: Add a test for block protection status bits
With refactoring out of the way we can add a test to make sure the region<>bpbits mapping is correct. Indeed we found that a number of configurations are incorrect.
The datasheets say that min/max bp values should protect either all or none of the flash depending on the cmp and tb bits. However we currently always return no protection for these values.
The test merely documents the current behavour, a fix will come in a later commit.
Change-Id: Ieb0632221203166288f9608c8492c1d4bd77dd36 Signed-off-by: Daniel Gröber dxld@darkboxed.org --- M src/drivers/spi/spi_flash.c M src/drivers/spi/spi_winbond.h M src/drivers/spi/winbond.c A tests/drivers/Makefile.inc A tests/drivers/spi-flash-winbond-test.c 5 files changed, 330 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/42117/26