Attention is currently required from: Jakub Czapiga.

Daniel Gröber (dxld) uploaded patch set #26 to this change.

View Change

spi/winbond: Add a test for block protection status bits

With refactoring out of the way we can add a test to make sure the
region<>bpbits mapping is correct. Indeed we found that a number of
configurations are incorrect.

The datasheets say that min/max bp values should protect either all or
none of the flash depending on the cmp and tb bits. However we currently
always return no protection for these values.

The test merely documents the current behavour, a fix will come in a
later commit.

Change-Id: Ieb0632221203166288f9608c8492c1d4bd77dd36
Signed-off-by: Daniel Gröber <dxld@darkboxed.org>
---
M src/drivers/spi/spi_flash.c
M src/drivers/spi/spi_winbond.h
M src/drivers/spi/winbond.c
A tests/drivers/Makefile.inc
A tests/drivers/spi-flash-winbond-test.c
5 files changed, 330 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/42117/26

To view, visit change 42117. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb0632221203166288f9608c8492c1d4bd77dd36
Gerrit-Change-Number: 42117
Gerrit-PatchSet: 26
Gerrit-Owner: Daniel Gröber (dxld) <coreboot@dxld.at>
Gerrit-Reviewer: Jakub Czapiga <jacz@semihalf.com>
Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Daniel Gröber <dxld@darkboxed.org>
Gerrit-CC: Jan Dabros <jsd@semihalf.com>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Jakub Czapiga <jacz@semihalf.com>
Gerrit-MessageType: newpatchset