Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35821 )
Change subject: [RFC]arch/x86: Only use BOOTBLOCK_NORMAL with an CMOS option table
......................................................................
Patch Set 1:
I assume you plan to use get_option() in a GCC bootblock
implementation? Then I would make it a `depends on
!C_ENVIRONMENT_BOOTBLOCK || USE_OPTION_TABLE`. I don't
see why we should tie the current implementation to the
option table.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35821
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2126e71c72951d11960f5d27d25eaa838854057d
Gerrit-Change-Number: 35821
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 06 Oct 2019 13:31:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment