Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 )
Change subject: mb/apple: Add MacBook Pro 8,1 support ......................................................................
Patch Set 11:
(5 comments)
https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... File Documentation/mainboard/apple/macbookpro8_1.md:
https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... PS11, Line 32: 00000000:00000fff fd
Does this get formatted as a block of code?
Yes.
https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... PS11, Line 57: - Thunderbolt : - FireWire
Do the respective controllers enumerate properly on PCIe?
Yes.
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/Kconfig:
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 1: BOARD_APPLE_MACBOOKPRO8_1
nit: This would read better if you separate the numbers: […]
Then we need to change macbookair4_2 and other ports as well. Changing it in only one board doesn't feel right.
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/early_init.c:
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 30: Hub
USB port, you mean? […]
This is what schematics says. And I don't see it routed to any OC# pin, or I'm stupid.
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 30: Analog
Really?
This is just a copy pasta that is used across the boards. Let's remove it from many boards in separate commit.