5 comments:
File Documentation/mainboard/apple/macbookpro8_1.md:
Patch Set #11, Line 32: 00000000:00000fff fd
Does this get formatted as a block of code?
Yes.
- Thunderbolt
- FireWire
Do the respective controllers enumerate properly on PCIe?
Yes.
File src/mainboard/apple/macbookpro8_1/Kconfig:
Patch Set #11, Line 1: BOARD_APPLE_MACBOOKPRO8_1
nit: This would read better if you separate the numbers: […]
Then we need to change macbookair4_2 and other ports as well. Changing it in only one board doesn't feel right.
File src/mainboard/apple/macbookpro8_1/early_init.c:
USB port, you mean? […]
This is what schematics says. And I don't see it routed to any OC# pin, or I'm stupid.
File src/mainboard/apple/macbookpro8_1/gma-mainboard.ads:
Patch Set #11, Line 30: Analog
Really?
This is just a copy pasta that is used across the boards. Let's remove it from many boards in separate commit.
To view, visit change 33151. To unsubscribe, or for help writing mail filters, visit settings.