EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35175 )
Change subject: mb/google/drallion: Update gpio config for drallion
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35175/9/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/gpio.c:
https://review.coreboot.org/c/coreboot/+/35175/9/src/mainboard/google/dralli...
PS9, Line 166: /* GPP_F1 */ PAD_CFG_GPI(GPP_F1, NONE, DEEP), /* DDR_CHA_EN_1P8 */
We should put this into early_gpio_table. F1/F2 based on Duncan's comment.https://review.coreboot.org/c/coreboot/+/35241
https://review.coreboot.org/c/coreboot/+/35175/9/src/mainboard/google/dralli...
PS9, Line 177: /* EMMC_DATA0 */ PAD_CFG_GPI(GPP_F12, NONE, DEEP), /* MEM_CONFIGO_1P8 */
We should put this into early_gpio_table. See here:https://review.coreboot.org/c/coreboot/+/35141/7/src/mainboard/google/dralli...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35175
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78f85a266eb42ea186ff896db5cde0a347339a71
Gerrit-Change-Number: 35175
Gerrit-PatchSet: 9
Gerrit-Owner: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Krzysztof M Sywula
krzysztof.m.sywula@intel.com
Gerrit-CC: Mathew King
mathewk@chromium.org
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-CC: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Comment-Date: Fri, 06 Sep 2019 03:36:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment