hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45398 )
Change subject: soc/mediatek/mt8192: add pmif driver ......................................................................
Patch Set 23:
(9 comments)
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/pmif_spi.h:
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/inc... PS7, Line 55: PMIC_BASE = 0x0000, : PMIC_SMT_CON1 = PMIC_BASE + 0x0032, : PMIC_DRV_CON1 = PMIC_BASE + 0x003a, : PMIC_FILTER_CON0 = PMIC_BASE + 0x0042, : PMIC_GPIO_PULLEN0_CLR = PMIC_BASE + 0x0098, : PMIC_RG_SPI_CON0 = PMIC_BASE + 0x0408, : PMIC_DEW_DIO_EN = PMIC_BASE + 0x040c, : PMIC_DEW_READ_TEST = PMIC_BASE + 0x040e, : PMIC_DEW_WRITE_TEST = PMIC_BASE + 0x0410, : PMIC_DEW_CRC_EN = PMIC_BASE + 0x0414, : PMIC_DEW_CRC_VAL = PMIC_BASE + 0x0416, : PMIC_DEW_RDDMY_NO = PMIC_BASE + 0x0424, : PMIC_RG_SPI_CON2 = PMIC_BASE + 0x0426, : PMIC_SPISLV_KEY = PMIC_BASE + 0x044a, : PMIC_INT_STA = PMIC_BASE + 0x0452, : PMIC_AUXADC_ADC7 = PMIC_BASE + 0x1096, : PMIC_AUXADC_ADC10 = PMIC_BASE + 0x109c, : PMIC_AUXADC_RQST0 = PMIC_BASE + 0x1108,
Please use either tabs or spaces for alignment.
Done
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/in... File src/soc/mediatek/mt8192/include/soc/pmif_sw.h:
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/in... PS14, Line 13: (0x00) : #define SWINF_FSM_REQ (0x02) : #define SWINF_FSM_WFDLE (0x04) : #define SWINF_FSM_WFVLDCLR (0x06) : #define SWINF_INIT_DONE (0x01)
no need to add () if this is a single number
Done
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/in... PS14, Line 25: x
always quote x as (x) if you're going to apply operations on it.
Done
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/pm... File src/soc/mediatek/mt8192/pmif_clk.c:
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/pm... PS14, Line 146: PROJECT_CODE, 0xb16);
align with the ( above. […]
Done
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/pm... PS14, Line 163: PMIC_CG_MD
align with the ( above
Done
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/pm... PS14, Line 166: 0
align with the ( above
Done
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/pm... PS14, Line 174: PMIC_WRAP_SWRST
align with the ( above
Done
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/pm... PS14, Line 176: PMIC_WRAP_SWRST
align with the ( above
Done
https://review.coreboot.org/c/coreboot/+/45398/14/src/soc/mediatek/mt8192/pm... PS14, Line 180: PMIC_CG_MD
align with the ( above
Done