Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79854?usp=email )
Change subject: mb/google/brox: Set up FW_CONFIG ......................................................................
Patch Set 8:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79854/comment/86923c2c_51ba326d : PS2, Line 10: making
Imperative mood: make
Done
https://review.coreboot.org/c/coreboot/+/79854/comment/858a6a88_e366b3e9 : PS2, Line 11: moving
move
Removed.
https://review.coreboot.org/c/coreboot/+/79854/comment/2409d673_6a507c38 : PS2, Line 11: Also, moving the storage devices to brox : overridetree.cb as they are specific to this board.
A separate commit would be nice.
Moved to https://review.coreboot.org/c/coreboot/+/79995
File src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79854/comment/7d57f07c_082b94cd : PS2, Line 180: device ref pcie4_0 on
Probably separate the PCIE with another CL?
Moved to https://review.coreboot.org/c/coreboot/+/79995
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79854/comment/05684750_7f0e8eb8 : PS1, Line 8: option STORAGE_UFS 0
If you think emmc might be added later, might be better to make this […]
Done
https://review.coreboot.org/c/coreboot/+/79854/comment/69a34347_747bf570 : PS1, Line 11: end
- It will likely need a field for WiFi Device (not sure if kernel will need a field for WLAN type a […]
Nick, can you review these fw config settings to make sure that they cover your conerns?